Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add protected median reset function #254

Merged
merged 5 commits into from
Aug 7, 2023
Merged

feat: add protected median reset function #254

merged 5 commits into from
Aug 7, 2023

Conversation

bayological
Copy link
Member

Description

  • This change adds a protected function to the median delta breaker that allows the reset of a stored median rate

Other changes

  • None

Tested

  • Added unit tests to verify the functionality

Related issues

Backwards compatibility

  • N/A

Documentation

  • N/A

philbow61
philbow61 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@philbow61 philbow61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛩️

nvtaveras
nvtaveras approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@philbow61 philbow61 merged commit 46ce2ce into develop Aug 7, 2023
16 checks passed
@philbow61 philbow61 deleted the feat/add-median-reset-function branch August 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbow61 philbow61 philbow61 approved these changes

@nvtaveras nvtaveras nvtaveras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[L-3] MedianDeltaBreaker previous rates can not be reset if needed
3 participants
@bayological @nvtaveras @philbow61